tglunde#80 Disable view comments outside of DDL (tglunde#82)

* tglunde#80 disable comments on views outside DDL

* tglunde#80 relation comment

* tglunde#80 whitespace control

* added view test with persist docs enabled

---------

Co-authored-by: Torsten Glunde <torsten.glunde@alligator-company.com>

dbt/include/exasol/macros/adapters.sql

@@ -122,8 +122,11 @@ AS
 {% endmacro %}
 
 {% macro exasol__alter_relation_comment(relation, relation_comment) -%}
-  {%- set comment = relation_comment | replace("'", '"') %}
-  COMMENT ON {{ relation.type }} {{ relation }} IS '{{ comment }}';
+  {# Comments on views are not supported outside DDL, see https://docs.exasol.com/db/latest/sql/comment.htm#UsageNotes #}
+  {%- if not relation.is_view %}
+    {%- set comment = relation_comment | replace("'", '"') %}
+    COMMENT ON {{ relation.type }} {{ relation }} IS '{{ comment }}';
+  {%- endif %}
 {% endmacro %}
 
 {% macro get_column_comment_sql(column_name, column_dict, apply_comment=false) -%}
@@ -145,12 +148,15 @@ AS
 {%- endmacro %}
 
 {% macro exasol__alter_column_comment(relation, column_dict) -%}
+  {# Comments on views are not supported outside DDL, see https://docs.exasol.com/db/latest/sql/comment.htm#UsageNotes #}
+  {%- if not relation.is_view %}
     {% set query_columns = get_columns_in_query(sql) %} 
     COMMENT ON {{ relation.type }} {{ relation }} (
     {% for column_name in query_columns %}
-        {{ get_column_comment_sql(column_name, column_dict) }} {{- ',' if not loop.last }}
+      {{ get_column_comment_sql(column_name, column_dict) }} {{- ',' if not loop.last }}
     {% endfor %}
     );
+  {%- endif %}
 {% endmacro %}
 
 {% macro persist_view_column_docs(relation, sql) %}

tests/functional/test_view_comment.py

@@ -0,0 +1,26 @@
+from dbt.tests.adapter.basic.test_generic_tests import BaseGenericTests
+import pytest
+
+from dbt.tests.adapter.basic.files import (
+    base_table_sql,
+    schema_base_yml,
+    generic_test_view_yml,
+    generic_test_table_yml,
+)
+
+class TestExasolViewComment(BaseGenericTests):
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "view_model.sql": """
+                {{config(
+                    materialized='view',
+                    persist_docs={"relation": true, "columns": true }
+                )}}
+                select * from {{ source('raw', 'seed') }}
+            """,
+            "table_model.sql": base_table_sql,
+            "schema.yml": schema_base_yml,
+            "schema_view.yml": generic_test_view_yml,
+            "schema_table.yml": generic_test_table_yml,
+        }