Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#80 Disable view comments outside of DDL #82

Merged
merged 4 commits into from
Jul 13, 2023
Merged

#80 Disable view comments outside of DDL #82

merged 4 commits into from
Jul 13, 2023

Conversation

marvinfromblueforte
Copy link
Collaborator

No description provided.

tglunde
tglunde approved these changes Jul 13, 2023
View reviewed changes
Copy link
Owner

@tglunde tglunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes accepted and added additional test for view with persisted docs.

@tglunde tglunde merged commit 299177e into tglunde:master Jul 13, 2023
tglunde added a commit that referenced this pull request Jul 13, 2023
@marvinfromblueforte @tglunde
#80 Disable view comments outside of DDL (#82)
b8f4111 
* #80 disable comments on views outside DDL

* #80 relation comment

* #80 whitespace control

* added view test with persist docs enabled

---------

Co-authored-by: Torsten Glunde <torsten.glunde@alligator-company.com>
tglunde added a commit that referenced this pull request Jul 13, 2023
@marvinfromblueforte @tglunde
#80 Disable view comments outside of DDL (#82)
9a022fe 
* #80 disable comments on views outside DDL

* #80 relation comment

* #80 whitespace control

* added view test with persist docs enabled

---------

Co-authored-by: Torsten Glunde <torsten.glunde@alligator-company.com>
peterkioko pushed a commit to GrantStreetGroup/dbt-exasol that referenced this pull request Nov 10, 2023
@marvinfromblueforte @tglunde
tglunde#80 Disable view comments outside of DDL (tglunde#82)
560d12b 
* tglunde#80 disable comments on views outside DDL

* tglunde#80 relation comment

* tglunde#80 whitespace control

* added view test with persist docs enabled

---------

Co-authored-by: Torsten Glunde <torsten.glunde@alligator-company.com>
peterkioko pushed a commit to GrantStreetGroup/dbt-exasol that referenced this pull request Nov 10, 2023
Pull request tglunde#3: pull_in_upstream_changes
d96698e 
Merge in GITHUB/dbt-exasol from pull_in_upstream_changes to master

* commit '2f99f8e37333cb91df0f4700269e34fcfdb1febd':
  xdist for parallel pytest execution added - mv & clone miss in readme (tglunde#108)
  95 dbt16 tests  (tglunde#99)
  Bump urllib3 from 1.26.16 to 1.26.18 (tglunde#106)
  Bump cryptography from 41.0.3 to 41.0.4 (tglunde#100)
  caching fix, removed table macro overwrite (tglunde#103)
  full refresh behaviour fix (tglunde#107)
  adding debug test (tglunde#98)
  version bump 16 && limit simple test added (tglunde#96)
  bugfix null handling csv hash test - version upgrade 1.6 (tglunde#97)
  poetry update && re-added 4ec4415 for adding multiple cols in exasol (tglunde#93)
  v1.5 tests, incremental merge, temp table fix (tglunde#86)
  89 contract tests fail after dbt core update from 151 to 152 (tglunde#92)
  source freshness timestamp parsing fix (tglunde#91)
  v1.5 model contracts (tglunde#87)
  Bump sqlfluff from 2.1.1 to 2.1.2 (tglunde#83)
  tglunde#80 Disable view comments outside of DDL (tglunde#82)
  adding parameter for OpenID login with access/refresh token (tglunde#79)
  Bump requests from 2.29.0 to 2.31.0 (tglunde#76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tglunde tglunde tglunde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinfromblueforte @tglunde