Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open multiprocessing logging inside context handler #35

Closed
codekiln opened this issue Aug 17, 2018 · 0 comments
Closed

open multiprocessing logging inside context handler #35

codekiln opened this issue Aug 17, 2018 · 0 comments
Assignees
@codekiln
Labels
bug Something isn't working

Comments

@codekiln
Copy link
Contributor

codekiln commented Aug 17, 2018 •
edited
Loading

Currently, we use the multiprocessing-logging package; see multiprocessing-logging on github. The package is initialized at the time django_elastic_migrations.utils.django_elastic_migrations_log is imported. This is a bug; we shouldn't initialize multiprocessing-logging until we are actually using multiprocessing.

Initialization should be moved to DjangoMultiProcess.enter, so that when the context manager for multiprocessing opens, multiprocessing logging is started.
@codekiln codekiln added the bug Something isn't working label Aug 17, 2018
@codekiln codekiln self-assigned this Aug 17, 2018
codekiln added a commit that referenced this issue Aug 20, 2018
@codekiln
#35 open multiprocessing log in context handler
3d4f449
@codekiln codekiln mentioned this issue Aug 20, 2018
Merged
codekiln added a commit that referenced this issue Aug 20, 2018
@codekiln
bump 0.7.4 --> 0.7.5
781c962 
* update changelog
* add test stub for django elastic migrations log

#35 open multiprocessing log in context handler
codekiln added a commit that referenced this issue Aug 20, 2018
@codekiln
add basic test for multiprocessing_utils so pr coverage does not go down
fdcf226 
#35 open multiprocessing log in context handler
codekiln added a commit that referenced this issue Aug 20, 2018
@codekiln
update basic multiprocessing logging test
edfee88 
#35 open multiprocessing log in context handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codekiln codekiln

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codekiln