#35 open multiprocessing log in context handler #36
Conversation
codekiln
requested review from
bwbensonjr,
esmail,
gnulnx,
kofic and
marinko-peso
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 64.16% 69.15% +4.99%
==========================================
Files 19 19
Lines 879 885 +6
Branches 134 135 +1
==========================================
+ Hits 564 612 +48
+ Misses 266 219 -47
- Partials 49 54 +5
Continue to review full report at Codecov.
|
| start multiprocessing-logging to make each handler a synchronized queue. | ||
| Called by django_elastic_migrations.utils.multiprocessing_utils.DjangoMultiProcess.__enter__ | ||
| See https://github.com/jruere/multiprocessing-logging/blob/master/multiprocessing_logging.py | ||
| TBD: uninstall mp_logging; currently we don't stop and reset mp logging; it's a one-shot for the process. |
There was a problem hiding this comment.
Question on this quote: "currently we don't stop and reset mp logging; it's a one-shot for the process."
Does this mean when you set mp_logging_enabled = True - it will still be activate even if you set it to False?
There was a problem hiding this comment.
Yes, mp_logging_enabled is set in this module and isn't meant to be set outside of it. There's currently no code that resets it to False once it's been set to True, because uninstalling multiprocessing logging isn't implemented or supported yet.
I've put in a feature request for that with multiprocessing_logging, which would involve making backups of all the logging and then reinstalling the backups after multiprocessing is complete.
This is really just a stub to prevent starting multiprocessing logging again if it's already initiated.
for #35 open multiprocessing log in context handler