Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2768 zap fix #517

Closed
wants to merge 174 commits into from
Closed

2768 zap fix #517

wants to merge 174 commits into from

Conversation

elipe17
Copy link
Contributor

@elipe17 elipe17 commented Apr 11, 2024

Summary of Changes

Provide a brief summary of changes
Pull request closes #_

How to Test

List the steps to test the PR
These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d
cd tdrs-backend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d 
  1. Open http://localhost:3000/ and sign in.
  2. Proceed with functional tests as described herein.
  3. Test steps should be captured in the demo GIF(s) and/or screenshots below.

Demo GIF(s) and screenshots for testing procedure

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

  • [insert ACs here]
  • lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?
    • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
    • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Are code maintainability principles being followed?

Deliverable 4: Accessible

  • Does this PR complete the epic?
  • Are links included to any other gov-approved PRs associated with epic?
  • Does PR include documentation for Raft's a11y review?
  • Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

  • Does this PR provide background for why coding decisions were made?
  • If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?
  • Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any new security issues?
  • If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

  • the purpose of the research
  • methods used to conduct the research
  • who participated in the research
  • what was tested and how
  • impact of research on TDP
  • (if applicable) final design mockups produced for TDP development

elipe17 and others added 29 commits April 1, 2024 10:08
Co-authored-by: Alex P.  <63075587+ADPennington@users.noreply.github.com>
Co-authored-by: Alex P.  <63075587+ADPennington@users.noreply.github.com>
* - Added new group and permissions
- Updated frontend to allow digit access to admin and kibana

* - Add test
- Update test
- Add fixture

* - Rename migration

* - removing debug print

* - Give digit team access to all parsed data

---------

Co-authored-by: Alex P <63075587+ADPennington@users.noreply.github.com>
Co-authored-by: Alex P.  <63075587+ADPennington@users.noreply.github.com>
…ookie

2822 fix webinspect medium priority - persistent session
2887 - 18A REC_OASDI_INSURANCE not mandatory
* local ES aggregate

* changes for elastic search instance needed

* linting

* corrected setting the env var for proxy.yml

* changed app name to one env

* corrected frontend deployment vars

* corrected command for sh

* EMR-2814 removed unused var in deploy frontend

* moved deploying kibana and es out to separate script

* md file added for script

* linting

* 2814 revert unnecessary changes

---------

Co-authored-by: Alex P <63075587+ADPennington@users.noreply.github.com>
@elipe17 elipe17 closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants