[Issue #1458]: Setup query param management - writing to the URL part 1 #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @andycochran |
andycochran
reviewed
Mar 12, 2024
rylew1
commented
Mar 12, 2024
rylew1
commented
Mar 12, 2024
| {/* TODO: href here needs to be set to: | ||
| dev/staging: https://grants.gov/search-results-detail/<opportunity_id> | ||
| local/prod: https://grants.gov/search-results-detail/<opportunity_id> | ||
| */} |
There was a problem hiding this comment.
Just a note to set the anchor link to the actual grant/opportunity - it differs for each environment
There was a problem hiding this comment.
FWIW, this is the same URL twice. eg. https://grants.gov/search-results-detail/<opportunity_id>
rylew1
commented
Mar 12, 2024
rylew1
changed the title
rylew1
commented
Mar 12, 2024
| @@ -20,20 +21,25 @@ export function SearchForm({ initialSearchResults }: SearchFormProps) { | |||
| initialSearchResults, | |||
| ); | |||
|
|
|||
| const formRef = useRef(null); | |||
There was a problem hiding this comment.
ref here allows us to submit from non button inputs (which are basically most our inputs since we just have one submit/search button in the SearchBar component
rylew1
commented
Mar 14, 2024
| const [mounted, setMounted] = useState(false); | ||
| const { updateQueryParams } = useSearchParamUpdater(); | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
I think we get to remove the eslint disable statement in the part 2 pr
coilysiren
approved these changes
Mar 14, 2024
|
Merging this PR is irrelevant since the pagination PR was branched off this and merged: #1480 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1458
Time to review: 5 min
Changes proposed
Context
status=forecasted,closed,archivedThis is just part 1 - I will need to come back for part 2 and set it to:
Demo
Screen.Recording.2024-03-12.at.4.35.22.PM.mov