Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #1477]: Hook up pagination #1480

Merged
merged 34 commits into from
Mar 16, 2024
Merged

[Issue #1477]: Hook up pagination #1480

merged 34 commits into from
Mar 16, 2024

Conversation

rylew1
Copy link
Contributor

@rylew1 rylew1 commented Mar 14, 2024 •
edited
Loading

Summary

Fixes #1477

Time to review: 5-10min

Changes proposed

  • Page changes update the URL
  • Updates to the URL also change the page

Context

  • This PR is branched off the 2 query param PR so it has a bunch of extra changes until we merge those

Demo

Screen.Recording.2024-03-14.at.7.46.09.AM.mov

rylew1 and others added 23 commits March 11, 2024 08:20
@rylew1
initial commit
069d171
@rylew1
Merge branch 'main' into rylew/1458-query-param-mgmt
5fbbf66
@rylew1
format
6d8c024
@rylew1
fix what's being imported
3b14e4c
@rylew1
update to custom hook
603b366
@rylew1
rename file and get sortby working with writing query params
41f6a9b
@rylew1
Merge branch 'main' into rylew/1458-query-param-mgmt
37679a2
@rylew1
fix mounted bug
65454f8
@rylew1
remove unnecessary imports
9c4878c
@rylew1
Update debounce time and todo for search results list link
abe700f
@rylew1
spacing
7c50e46
@rylew1
changeSearchResultsHeader prop to searchResultsLength
b52175c
@rylew1
Merge branch 'main' into rylew/1458-query-param-mgmt
f20a7f2
@rylew1
update to one cleaner hook function that updates from any component
078590c
@rylew1
update useSearchParamUpdater.test to reference new fn
774bcd4
@rylew1
add a test for searchopportunitystatus
0ddaf43
@rylew1
add additional commented out tests
e59c116
@rylew1
initial working reading from QP
f42df0c
@rylew1
fix status test
ee81b7a
@rylew1
format
2468c1a
@rylew1
Merge branch 'main' into rylew/1458-reading-query-params-part-2
4919972
@rylew1
push whitespace
fcdd844
@rylew1
initial commit
4472846
andycochran
andycochran reviewed Mar 14, 2024
View reviewed changes
frontend/src/components/search/SearchResultsList.tsx Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bit more that needs to be done here. The dates should be conditional, based on the status — e.g. only show the "Closing" tag if the opportunity is accepting applications, and instead show a "Forecasted" tag wqhen necessary, and no tag if closed/archived. But let's handle that in another PR.

@rylew1 rylew1 marked this pull request as ready for review March 14, 2024 14:47
@rylew1 rylew1 requested a review from andycochran March 14, 2024 15:07
@rylew1 rylew1 merged commit 5d50bc4 into main Mar 16, 2024
9 checks passed
@rylew1 rylew1 deleted the rylew/1477-hook-up-pagination branch March 16, 2024 01:37
This was referenced Mar 16, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acouch acouch acouch approved these changes

@SammySteiner SammySteiner Awaiting requested review from SammySteiner

@andycochran andycochran Awaiting requested review from andycochran andycochran is a code owner

Assignees
No one assigned
Labels
frontend typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Hookup pagination to query params and search results
3 participants
@rylew1 @andycochran @acouch