[Issue #1229] Dynamic tag format in search results #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycochran
requested review from
coilysiren,
rylew1 and
chouinar
and removed request for
SammySteiner
rylew1
reviewed
Mar 22, 2024
rylew1
reviewed
Mar 22, 2024
rylew1
reviewed
Mar 22, 2024
| </div> | ||
| </div> | ||
| <li key={opportunity?.opportunity_id}> | ||
| <SearchResultsListItem opportunity={opportunity} /> |
rylew1
reviewed
Mar 22, 2024
| : "--"} | ||
| </span> | ||
| )} | ||
| {opportunity?.opportunity_status === "posted" && ( |
There was a problem hiding this comment.
nit: you might try getPosted() getArchived() functions that return the JSX. And/or a javascript switch statement to clean some of this up. Just a nit though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1229
Time to review: 5 mins
Changes proposed
Context for reviewers
--
Additional information