-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI init #55
GUI init #55
Conversation
I pulled down this PR locally and tried building but got this error:
The build failed after that, did this happen to you at all? |
The PR builds fine for me and runs. |
Ran into two somewhat easy hiccups, and a third which I am currently working on. Some things:
I'll let you guys know more when I get it working. |
Thanks. If it requires |
Nope! Used my Ubuntu machine. |
@Sl1mb0 let me know if you still are getting issues. I did remember getting something very similar to that, with the same error message. I'm going to look through it again and see what I did to fix it. Thanks for recording that! Edit: Have you tried installing these packages?
|
I have built it successfully. In addition to the dependencies listed previously there are also these dependencies that I installed:
Edit: Not sure how we should address these issues for our our project, I just know that we should include something about these dependencies somewhere. I got this message when running
But other than that it opened up fine. It looks awesome @ScherrerMichael, great job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I would suggest is breaking up src/gui/mod.rs
into separate, smaller, sub-modules so that navigating the gui
module is easier.
Just spitballing, but you could maybe do something like this:
src/gui/state.rs
src/gui/content.rs
...
Cool!! This worked for me, but I'm pretty sure I had everything above already installed on my computer. I did notice when resizing the window to be pretty small, the "Launch" button loses its text, but stays near the bottom of the pane and turns comically tiny-- maybe we could find out how to keep the button text when it shrinks. Other than that, I don't love how everything is in This is so awesome! Great work on this and thank you! |
I separated the Thanks everyone! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for doing this!
Please try it out!
To run: do
./perf-rust gui
Please Note:
Loaded(state)
function and thePerfEvent
enums. I feel like once we figure this out, we can make graphics later!I would like to update this PR every time a perf event is added.