Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markdown on tasks do not work when using line breaks #2049

Closed
rilygreat opened this issue Dec 4, 2023 · 2 comments · Fixed by #2080
Closed

markdown on tasks do not work when using line breaks #2049

rilygreat opened this issue Dec 4, 2023 · 2 comments · Fixed by #2080
Labels
Help wanted Type: Bug

Comments

@rilygreat
Copy link

Device: samsung Galaxy S8
Android Version: 28
AppVersion: Version 4.3 (6731)
User ID: ca543acf-fc03-480d-a0c4-27a12670f5d0
Level: 113
Class: healer
Is in Inn: false
Uses Costume: true
Custom Day Start: 3
Timezone Offset: -60
Details:

Hello!
I found a small bug, nothing serious but I use/rely on this function a lot so I thought I'd report it.

Basically the formatting doesn't work properly on my app. I've attached some screenshots to explain myself better.
Take picture 1: I'm trying to create a task where the description has text both in italic and in bold. When I save it, the result is as shown in picture 2.

If I try to use only one formatting at a time, however, both work fine, as shown in picture 3 and 4.

1
2
3
4
@EanLombardo
Copy link
Contributor

Can I take this on, I was digging through the markdown code today and I think this is due to a small oversight with regexes that is trivial to fix.

EanLombardo added a commit to EanLombardo/habitica-android that referenced this issue Jul 13, 2024
@EanLombardo
Check that a string contains markdown symbols instead of matches
77967aa 
.* does not match line breaks, so this regex would never apply to multiline text. This checks for contains instead of using .* to account for this.

Fixes HabitRPG#2049
@EanLombardo EanLombardo mentioned this issue Jul 13, 2024
Merged
phillipthelen pushed a commit that referenced this issue Sep 5, 2024
@EanLombardo
Check that a string contains markdown symbols instead of matches (#2080)
1385062 
.* does not match line breaks, so this regex would never apply to multiline text. This checks for contains instead of using .* to account for this.

Fixes #2049
@saraolson
Copy link
Collaborator

this will be fixed in android 4.4.2

phillipthelen pushed a commit that referenced this issue Sep 10, 2024
@EanLombardo @phillipthelen
Check that a string contains markdown symbols instead of matches (#2080)
be91359 
.* does not match line breaks, so this regex would never apply to multiline text. This checks for contains instead of using .* to account for this.

Fixes #2049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help wanted Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check that a string contains markdown symbols instead of matches EanLombardo/habitica-android
3 participants
@EanLombardo @saraolson @rilygreat