Check that a string contains markdown symbols instead of matches #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.* does not match line breaks, so this regex would never apply to multiline text. This checks for contains instead of using .* to account for this. Fixes HabitRPG#2049
|
@EanLombardo Thanks for your contribution! We're working on an iOS update right now, but when we finish that and return to android we'll review and test this PR. When everything looks good, we'll add it to your Habitica profile :) |
|
@EanLombardo Thanks for your patience! I've gone ahead and added a record of this contribution to your Habitica profile and awarded you a contributor tier 🎉 your PR will be included in the next Android update, 4.4.2 |
phillipthelen
pushed a commit
that referenced
this pull request
Sep 10, 2024
.* does not match line breaks, so this regex would never apply to multiline text. This checks for contains instead of using .* to account for this. Fixes #2049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.* does not match line breaks, so this regex would never apply to multiline text. This checks for contains instead of using .* to account for this.
Fixes #2049
my Habitica User-ID: 297173d0-c9f8-4eb3-818c-53f699214c98