Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unable to scroll through the discover challenge list due to the list "jumping" #1307

Closed
rilygreat opened this issue Jul 10, 2023 · 3 comments · Fixed by #1330
Closed

unable to scroll through the discover challenge list due to the list "jumping" #1307

rilygreat opened this issue Jul 10, 2023 · 3 comments · Fixed by #1330
Labels
Help wanted Priority: minor Type: Bug

Comments

@rilygreat
Copy link

The following lines help us find and squash the Bug you encountered. Please do not delete/change them.
iOS Version: 16.5.1
Device: iPhone14,4
App Version: 3.7.3 (879)
User ID: 0a69bb45-3c0c-42bf-9bc5-730a957783c9
Level: 123
Class: healer
Is in Inn: false
Uses Costume: true
Custom Day Start: 0

Please describe the bug you encountered:
When scrolling through the discover challenges tab, it will keep glitching and moving you back up towards the top of the page. You can’t keep scrolling through as it will quite consistently do this, so you can only see the same 20-30 challenges as it will jump back up before you can get any further
@saraolson
Copy link
Collaborator

im guessing this is an issue with how we handle lazy load for the challenge list..?

JBYoshi added a commit to JBYoshi/habitica-ios that referenced this issue Apr 6, 2024
@JBYoshi
Fix challenge sort order to match the server-side ordering.
1ac794d 
The app was sorting the challenges by decreasing member count, but the server
returns challenges in order of creation date (with official challenges overriding
the ordering). This should fix the challenges jumping around.

Fixes HabitRPG#1307.
JBYoshi added a commit to JBYoshi/habitica-ios that referenced this issue Apr 6, 2024
@JBYoshi
Fix challenge sort order to match the server-side ordering.
815f2b4 
The app was sorting the challenges by decreasing member count, but the server
returns challenges in order of creation date (with official challenges overriding
the ordering). This should fix the challenges jumping around.

Fixes HabitRPG#1307.
@JBYoshi JBYoshi mentioned this issue Apr 6, 2024
Merged
@JBYoshi
Copy link
Contributor

JBYoshi commented Apr 6, 2024

I think I've traced this down to a mismatch between the challenge sort order on the server (official challenges on top, then from newest to oldest) and the app (most members first). I submitted #1330 to fix this.

@saraolson
Copy link
Collaborator

Thanks for your help with this! We're working on a rather large release right now, but once that's out of the way we'll be back to reviewing and merging PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help wanted Priority: minor Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix challenge sort order to match the server-side ordering. JBYoshi/habitica-ios
3 participants
@saraolson @JBYoshi @rilygreat