Fix challenge sort order to match the server-side ordering. #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app was sorting the challenges by decreasing member count, but the server returns challenges in order of creation date (with official challenges overriding the ordering). This should fix the challenges jumping around. Fixes HabitRPG#1307.
|
👍 LGTM! |
|
@JBYoshi Thanks so much for your contribution and patience! Everything worked well in testing and this PR will be released in the update we plan to send out next week. I've added this contribution to your Habitica profile and granted you tier 2 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iOS app was sorting the challenges by decreasing member count, but the server returns challenges in order of creation date (with official challenges overriding the ordering). This mismatch seems to be what's causing #1307; my initial tests with this fix don't show the list jumping around anymore.
Fixes #1307.
My Habitica User-ID: 32f74d6d-f010-473c-9527-da0bc5914ac8