Remove BindVisitor dependency given it's deprecated in Arel 9.0 #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5.2 requires Arel 9.0, which is what we're at; whereas the gem depends on Arel 8.0.
arel/visitors/visitor
was removed in Arel 9.0; note that this was required for MySQL adapter only, and we don't need that. Patching this so it can be compatible with our use case.This PR is probably not going to be merged; the plan is that cnce the original gem has fixed this, we can pull the original gem instead. Some PR pending in that repo: localytics#26
CI failed, seems unrelated 🤔
I ran the changes locally and it seems to work with core.