Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BindVisitor dependency given it's deprecated in Arel 9.0 #1

Merged
merged 3 commits into from
Aug 15, 2019

Conversation

pwen
Copy link

@pwen pwen commented Aug 15, 2019

Rails 5.2 requires Arel 9.0, which is what we're at; whereas the gem depends on Arel 8.0.
arel/visitors/visitor was removed in Arel 9.0; note that this was required for MySQL adapter only, and we don't need that. Patching this so it can be compatible with our use case.

This PR is probably not going to be merged; the plan is that cnce the original gem has fixed this, we can pull the original gem instead. Some PR pending in that repo: localytics#26

CI failed, seems unrelated 🤔

sql: could not connect to server: No such file or directory
	Is the server running locally and accepting
	connections on Unix domain socket "/var/run/postgresql/.s.PGSQL.5432"?
The command "bin/ci-setup" failed and exited with 2 during .

I ran the changes locally and it seems to work with core.

@pwen pwen requested review from jobertabma and bwillis August 15, 2019 18:25
@pwen pwen self-assigned this Aug 15, 2019
lib/odbc_adapter/adapters/null_odbc_adapter.rb Outdated Show resolved Hide resolved
class BindSubstitution < Arel::Visitors::ToSql
include Arel::Visitors::BindVisitor
end

# Using a BindVisitor so that the SQL string gets substituted before it is

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps update this comment, too.

@pwen pwen merged commit 517259e into master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants