Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to AR 5.2.1 and arel 9.0.0 #26

Closed
wants to merge 1 commit into from

Conversation

neroleung
Copy link

The newer versions of arel no longer have arel/visitors/bind_visitor. Need to require 'arel/visitors/visitor' instead.

@epbarger
Copy link

I'd love to see this merged!

@ianjhuang
Copy link

same!

@GPif
Copy link

GPif commented Mar 20, 2019

I tested and had this exception :

NameError: uninitialized constant Arel::Visitors::BindVisitor
from /Users/gg/.rvm/gems/ruby-2.3.1/bundler/gems/odbc_adapter-89b91d009e91/lib/odbc_adapter/adapters/null_odbc_adapter.rb:8:in `<class:BindSubstitution>'

I did a diffrent modification here

@lucasprag
Copy link

hey @thomasvidas, @bbc88ks and @kddeisz, any news on this? 🙏 🙏

divoxx pushed a commit to doximity/odbc_adapter that referenced this pull request Aug 11, 2023
Update odbc-ruby gem.
Update version number.
@prostko
Copy link

prostko commented Dec 13, 2024

Hey can we get this merged? Thanks!

@neroleung
Copy link
Author

Closing this because I no longer use this, and I don't remember what this is about anymore.

@neroleung neroleung closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants