Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enzyme to RTL (datepicker_test.test.js) #4569

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

yuki0410-dev
Copy link
Contributor

Continuation from last time PR(#4559);

Ref #4300

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@yuki0410-dev you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 488
- 575

100% JavaScript (tests)

Type of change

Fix - These changes are likely to be fixing a bug or issue.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (f41bd1b) to head (b4d4264).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4569   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files          28       28           
  Lines        2561     2561           
  Branches     1074     1074           
=======================================
  Hits         2481     2481           
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martijnrusschen
Copy link
Member

This is looking great. Massive effort!

@martijnrusschen martijnrusschen merged commit c4296e4 into Hacker0x01:main Mar 8, 2024
6 checks passed
@yuki0410-dev yuki0410-dev deleted the feat/useRTL branch March 8, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants