fix: enzyme to RTL (some files) #4559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@yuki0410-dev you can click here to see the review status or cancel the code review job.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4559 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 29 29
Lines 2579 2579
Branches 1069 1069
=======================================
Hits 2467 2467
Misses 112 112 ☔ View full report in Codecov by Sentry. |
yuki0410-dev
commented
Mar 5, 2024
| @@ -189,7 +189,10 @@ export default class DatePicker extends React.Component { | |||
| injectTimes: PropTypes.array, | |||
| inline: PropTypes.bool, | |||
| isClearable: PropTypes.bool, | |||
| toggleCalendarOnIconClick: PropTypes.func, | |||
| toggleCalendarOnIconClick: PropTypes.oneOfType([ | |||
There was a problem hiding this comment.
Fixed due to deviation from the default value, type bool.
|
This is great, and appreciate the effort! Ideally we would remove all enzyme usage from this repo. |
martijnrusschen
approved these changes
Mar 5, 2024
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we heard that the new tests were going to use RTL instead of enzyme, we decided that we needed to rewrite the existing tests with RTL.
Since I do not have the time to change everything at once, I created this PR to try to change things little by little.
(Sorry if there is an existing issue, PR.)
ref #4300