-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go1.12 got error parsing go.mod: unexpected module path "github.com/HdrHistogram/hdrhistogram-go" #30
Comments
Hi, the original repository has been moved to a new github location, please update your src directory accordingly (you need to remove the old clone and issue another get from the new location). |
Edit: This problem seems to have just gone away in my env. See my comment below. This rename has caused transitive dependency issues. Any module that depended on the old For instance, jaegertracing/jaeger-client-go depends on jaegertracing/jaeger-lib, which depends on The import in that file now breaks To resolve my problem in particular, I plan to PR the name change into However, in case others aren't in direct control of their dependency on this module and are looking for a solution, you can use a
|
I will have a try. Thanks! |
@mammothbane please check if this PR will fix the issue on jaeger-lib jaegertracing/jaeger-lib#82 |
@filipecosta90 Thanks for doing this — and I'm sorry I didn't update my comment, but this has stopped breaking for me. I was fighting this for about 6 hours on Monday and I started making a PR into jaeger-lib myself, but on Tuesday morning, the issue spontaneously went away and I've been able to build again without any problems since. I have no idea what changed — it very consistently didn't work on previously — but I can't make it happen anymore. If you're experiencing the problem, sorry, but I can no longer test a fix. |
This MR bb05e18 changed module path, while using go mod in go1.12 occurs this error:
go: github.com/codahale/hdrhistogram@v0.0.0-20200919145931-8dac23c8dac1: parsing go.mod: unexpected module path "github.com/HdrHistogram/hdrhistogram-go"
The text was updated successfully, but these errors were encountered: