Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] updated hdrhistogram dependency to HdrHistogram org repo #82

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

filipecosta90
Copy link
Contributor

@filipecosta90 filipecosta90 commented Sep 23, 2020

The codahale/hdrhistogram repo has been transferred under the github HdrHstogram umbrella with the help from the original author in Sept 2020 (new repo url https://github.com/HdrHistogram/hdrhistogram-go). The main reasons are to group all implementations under the same roof and to provide more active contribution from the community as the original repository was archived several years ago.

Unfortunately such URL change will break go applications that depend on this library directly or indirectly, as discussed here.

The dependency URL should be modified to point to the new repository URL. The tag "v0.9.0" was applied at the point of transfer and will reflect the exact code that was frozen in the original repository.

This PR updates the dependency, thus fixes #81

Signed-off-by: filipecosta90 <filipecosta.90@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #82    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           26        26            
  Lines          890       695   -195     
==========================================
- Hits           890       695   -195     
Impacted Files Coverage Δ
metrics/metricstest/local.go 100.00% <ø> (ø)
metrics/keys.go 100.00% <0.00%> (ø)
sample/sample.go 100.00% <0.00%> (ø)
metrics/factory.go 100.00% <0.00%> (ø)
metrics/metrics.go 100.00% <0.00%> (ø)
metrics/stopwatch.go 100.00% <0.00%> (ø)
utils/rate_limiter.go 100.00% <0.00%> (ø)
metrics/multi/multi.go 100.00% <0.00%> (ø)
metrics/tally/factory.go 100.00% <0.00%> (ø)
metrics/tally/metrics.go 100.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a87ae9d...e18d9c5. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codahale/hdrhistogram repo url has been transferred under the github HdrHstogram umbrella
2 participants