Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew: remove most traces of python@2 #7019

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Feb 10, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@iMichka iMichka self-assigned this Feb 10, 2020
@iMichka
Copy link
Member Author

iMichka commented Feb 10, 2020

This might need a few more passes.

Copy link
Contributor

@jonchang jonchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some copy edits

Library/Homebrew/exceptions.rb Outdated Show resolved Hide resolved
Library/Homebrew/exceptions.rb Outdated Show resolved Hide resolved
docs/Gems,-Eggs-and-Perl-Modules.md Outdated Show resolved Hide resolved
docs/Gems,-Eggs-and-Perl-Modules.md Outdated Show resolved Hide resolved
docs/Homebrew-and-Python.md Outdated Show resolved Hide resolved
docs/Homebrew-and-Python.md Outdated Show resolved Hide resolved
@iMichka iMichka requested a review from jonchang February 18, 2020 21:57
@iMichka iMichka added documentation Documentation changes python Homebrew/brew's python support labels Feb 18, 2020
@MikeMcQuaid MikeMcQuaid merged commit f6631d6 into Homebrew:master Mar 4, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @iMichka!

@iMichka iMichka deleted the python2doc branch March 4, 2020 12:31
@lock lock bot added the outdated PR was locked due to age label Apr 4, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation changes outdated PR was locked due to age python Homebrew/brew's python support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants