-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name collision with brew: platypus #2440
Comments
Rename resolves file name collision noted in Issue Homebrew#2440. Also renamed cask class for consistency with cask naming guidelines.
I can confirm the warning at update time, but then had no problems installing or uninstalling platypus via |
What is the output you get with We have a bunch of casks in common with homebrew, and none of them pose a problem, so this one should not be any different. Renaming it is, then, not an acceptable solution. |
@rolandwalker If that's the case, I'll just close it. I was a bit overeager here. |
@vitorgalvao Thank you for your help! I'll try the script. I agree with you that renaming is not an acceptable solution. The intent of the PR was a quick kludge intended to demonstrate both one possible solution and a willingness to contribute in the hopes of finding a better solution. Your solution is much better.
When I see italics like that, I read it as some sort of sneer or sarcasm, and don't appreciate it. That said, I see you've used it on other posts, so I also get the impression that such a connotation is not what you're trying to get across. What are you getting at with the italics for "casks" and "homebrew"? Did I use terminology incorrectly? Is there something I could do better? I like this project, and if there's something I could do to be of more help, let me know. Here is the output from
|
@goxberry, you might have Casks in I would like to make the new |
@goxberry Apologies for that, I actually never thought it could be interpreted that way. As you’ve noticed, I use italics in those words every time, since they are discrete and pertain to something directly to do with project information. Words like “homebrew”, “cask”, “class”, “function”, and the like, are not exclusive to programming and can be used in both senses when writing about the subject (some more commonly than others, but I try to be consistent), so I try to differentiate them. Writing them in code tags makes them look so different that your eyes stop when seeing them, making for a worse (and possibly confusing, when there are a lot) reading experience, so I found italics to be a nice in-between. In sum, my goal with them is to make it easy to distinguish between “now I’m referring to the noun we use in everyday speech” (the function of a piece of code) and “now I’m talking about something that deals specifically with the project” (a code function). Calling it a “magical” one-liner probably made my reply sound snarky, too, but I’ve been a part of this project for a long time, and in the beginning (until the issue was fixed), the problem that caused the error that one-liner fixes occurred every time a new cask was added (as you can imagine, it was quite often), and users were required to do that. So to me it’s a funny memory mentioning it once more, as that line is really the correct answer to a lot of issues, to a point that it feels like it can actually solve every user problem in homebrew-cask, as if by magic. Again, apologies for the confusion. To end, there was nothing wrong with your solution or the way you handled the issue. I try to be cordial in every reply, but there are so many issues and pull requests coming in all the time that formalities are cut to a minimum. When you spend this much time writing on issues, there’s a difficult balance to strike between brevity and warmness. I (and I’m pretty confident I could have written “we”) appreciate your contribution and interest in the project, and hope to see more. Again, there was nothing wrong with the way you thought about this, and it is valuable that you started a discussion on possible fixes, it’s just that in this case, an alternative and already in place convention was already known. |
@vitorgalvao No worries! It was a misunderstanding on my part. Lots of shell scripts look like magic to me anyway, even if (especially if?) I understand what they do. With the volume of issues you guys get, the need to be succinct is understandable, and I appreciate the time that you and the other maintainers put into the project. It helps me (and I'm sure other people as well) a lot with managing the software on my machine, and I look forward to seeing this project grow! (And hopefully, submitting more PRs!) |
@rolandwalker Will you be on IRC this weekend? (Also, I've never been on IRC, so I will need to figure out how to do that.) |
weekend yes, or find my email address inside source code at my profile page, IRC coordinates are in |
Just did a
brew update
, and sawPerhaps renaming the cask here would be best? I'm going to do a little research and see if I can come up with a quick fix.
The text was updated successfully, but these errors were encountered: