Rename platypus to platypus-app. #2442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename resolves file name collision noted in Issue Homebrew#2440. Also renamed cask class for consistency with cask naming guidelines.
|
Renaming is not the best solution, and we can solve this without resorting to it, so I’ll close this for now. See my comment on your other issue for details and a possible fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename resolves file name collision noted in Issue #2440. Also renamed
cask class for consistency with cask naming guidelines.
I'm not particularly wedded to the idea of appending
-appto casks thatconflict with source code brew formulas; I'm happy to modify my PR to
whatever convention the project wishes to adopt. Conceivably, this
issue could come up again, as there are many projects that distribute
binary executables and source code downloads, so it would probably be
a good idea to have a policy in mind for this type of collision.