-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssl@3: fix OPENSSL_LIBRARY_DIR
in OpenSSLConfig.cmake
#169721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Cho <michael@michaelcho.dev>
cho-m
added
the
CI-no-fail-fast
Continue CI tests despite failing GitHub Actions matrix builds.
label
Apr 22, 2024
github-actions
bot
added
the
CI-skip-recursive-dependents
Pass --skip-recursive-dependents to brew test-bot.
label
Apr 22, 2024
cho-m
added
long build
Set a long timeout for formula testing
CI-linux-self-hosted
Build on Linux self-hosted runner
labels
Apr 22, 2024
Possibly related: #169728 |
iMichka
added
the
CI-long-timeout
[DEPRECATED] Use longer GitHub Actions CI timeout.
label
Apr 23, 2024
|
github-actions
bot
removed
the
CI-long-timeout
[DEPRECATED] Use longer GitHub Actions CI timeout.
label
Apr 23, 2024
|
fxcoudert
approved these changes
Apr 24, 2024
github-actions
bot
added
the
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
label
Apr 24, 2024
nijel
added a commit
to nijel/weblate
that referenced
this pull request
Apr 25, 2024
We need fixed openssl for Homebrew/homebrew-core#169721.
5 tasks
nijel
added a commit
to WeblateOrg/weblate
that referenced
this pull request
Apr 25, 2024
We need fixed openssl for Homebrew/homebrew-core#169721.
13 tasks
maxfierke
added a commit
to maxfierke/mstrap
that referenced
this pull request
Apr 28, 2024
Static libs are missing for OpenSSL@3 in current GitHub Actions macOS-14 runner image is broken until it pulls in Homebrew/homebrew-core#169721 Removed "install from API" config too, since auto upgrades are disabled anyway.
maxfierke
added a commit
to maxfierke/mstrap
that referenced
this pull request
Apr 28, 2024
Static libs are missing for OpenSSL@3 in current GitHub Actions macOS-14 runner image is broken until it pulls in Homebrew/homebrew-core#169721 Removed "install from API" config too, since auto upgrades are disabled anyway.
maxfierke
added a commit
to maxfierke/mstrap
that referenced
this pull request
Apr 28, 2024
Static libs are missing for OpenSSL@3 in current GitHub Actions macOS-14 runner image is broken until it pulls in Homebrew/homebrew-core#169721 Removed "install from API" config too, since auto upgrades are disabled anyway.
maxfierke
added a commit
to maxfierke/mstrap
that referenced
this pull request
Apr 28, 2024
Static libs are missing for OpenSSL@3 in current GitHub Actions macOS-14 runner image is broken until it pulls in Homebrew/homebrew-core#169721 Removed "install from API" config too, since auto upgrades are disabled anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CI-linux-self-hosted
Build on Linux self-hosted runner
CI-no-fail-fast
Continue CI tests despite failing GitHub Actions matrix builds.
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
CI-skip-recursive-dependents
Pass --skip-recursive-dependents to brew test-bot.
long build
Set a long timeout for formula testing
outdated
PR was locked due to age
ready to merge
PR can be merged once CI is green
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?OpenSSL 3.3 introduced CMake files, but the installed file's
OPENSSL_LIBRARY_DIR
is wrong:This looks like due to using an absolute path for
--libdir
. Documentation says:Seen in
snappy
PR which fails to buildlibpulsar
due to wrong path (partly as a side effect of setting-DCMAKE_FIND_PACKAGE_PREFER_CONFIG=ON
so new CMake config is used rather than module) - https://github.com/Homebrew/homebrew-core/actions/runs/8778078486/job/24084058696?pr=168100#step:3:195