Support pnpm #56
Merged
Support pnpm #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For has_command?, we can cache output & use Process.find_executable instead of calling a bunch of shell subprocesses for a bit of speed up
This adds support for pnpm as a package manager, but not as a runtime manager for Node (aka `pnpm env`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for pnpm as a package manager, but not as a runtime manager for Node (aka
pnpm env). Rolling w/ brew-installed version for now (same asyarn), though not entirely sure that's what should be done (for either). This might be okay in most cases, but depending on howcorepackends up, that's probably what should be used instead.(macOS build failing due to the GitHub Actions macOS runners not having picked up Homebrew/homebrew-core#169721)