Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 23.4.0 #200689

Merged
merged 2 commits into from
Dec 11, 2024
Merged

node 23.4.0 #200689

merged 2 commits into from
Dec 11, 2024

Conversation

BrewTestBot
Copy link
Member

@BrewTestBot BrewTestBot commented Dec 10, 2024

Created by brew bump


Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing icu4c ICU use is a significant feature of the PR or issue long dependent tests Set a long timeout for dependent testing labels Dec 10, 2024
@stefanb stefanb added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Dec 11, 2024
@ollietreend

This comment was marked as off-topic.

@SMillerDev
Copy link
Member

ESBuild seems unrelated:

  ==> Testing esbuild
  ==> /opt/homebrew/opt/node/libexec/bin/npm install react react-dom
  
  added 3 packages in 1s
  ==> /opt/homebrew/Cellar/esbuild/0.24.0/bin/esbuild app.jsx --bundle --outfile=out.js
  
    out.js  746.3kb
  
  ⚡ Done in 16ms
  ==> node out.js
  Killing child processes...
  ==> Testing esbuild (again)
  ==> /opt/homebrew/opt/node/libexec/bin/npm install react react-dom
  
  added 3 packages in 899ms
  ==> /opt/homebrew/Cellar/esbuild/0.24.0/bin/esbuild app.jsx --bundle --outfile=out.js
  
    out.js  746.3kb
  
  ⚡ Done in 14ms
  ==> node out.js
  Killing child processes...
  Error: esbuild: failed
  An exception occurred within a child process:
    Timeout::Error: execution expired
  /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/lib/ruby/3.3.0/timeout.rb:43:in `rescue in handle_timeout'
  /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/lib/ruby/3.3.0/timeout.rb:40:in `handle_timeout'
  /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/lib/ruby/3.3.0/timeout.rb:195:in `timeout'
  /opt/homebrew/Library/Homebrew/test.rb:54:in `<main>'

@ryenus
Copy link
Contributor

ryenus commented Dec 11, 2024

How about adding process.exit() at the end of the test script?

@chenrui333
Copy link
Member

will followup on the esbuild test.

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 11, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit 6d064c4 Dec 11, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-node-23.4.0 branch December 11, 2024 16:39
@chenrui333 chenrui333 mentioned this pull request Dec 11, 2024
6 tasks
@chenrui333
Copy link
Member

How about adding process.exit() at the end of the test script?

updating in #200808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. icu4c ICU use is a significant feature of the PR or issue long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants