-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node 23.4.0 #200689
Merged
Merged
node 23.4.0 #200689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bump-formula-pr
PR was created using `brew bump-formula-pr`
long build
Set a long timeout for formula testing
icu4c
ICU use is a significant feature of the PR or issue
long dependent tests
Set a long timeout for dependent testing
labels
Dec 10, 2024
stefanb
force-pushed
the
bump-node-23.4.0
branch
from
December 10, 2024 17:52
c1628e3
to
627f38d
Compare
iMichka
approved these changes
Dec 10, 2024
stefanb
added
the
CI-no-fail-fast-deps
Continue dependent tests despite failing GitHub Actions matrix tests.
label
Dec 11, 2024
stefanb
force-pushed
the
bump-node-23.4.0
branch
from
December 11, 2024 05:56
627f38d
to
ce0d600
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
ESBuild seems unrelated: ==> Testing esbuild
==> /opt/homebrew/opt/node/libexec/bin/npm install react react-dom
added 3 packages in 1s
==> /opt/homebrew/Cellar/esbuild/0.24.0/bin/esbuild app.jsx --bundle --outfile=out.js
out.js 746.3kb
⚡ Done in 16ms
==> node out.js
Killing child processes...
==> Testing esbuild (again)
==> /opt/homebrew/opt/node/libexec/bin/npm install react react-dom
added 3 packages in 899ms
==> /opt/homebrew/Cellar/esbuild/0.24.0/bin/esbuild app.jsx --bundle --outfile=out.js
out.js 746.3kb
⚡ Done in 14ms
==> node out.js
Killing child processes...
Error: esbuild: failed
An exception occurred within a child process:
Timeout::Error: execution expired
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/lib/ruby/3.3.0/timeout.rb:43:in `rescue in handle_timeout'
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/lib/ruby/3.3.0/timeout.rb:40:in `handle_timeout'
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/lib/ruby/3.3.0/timeout.rb:195:in `timeout'
/opt/homebrew/Library/Homebrew/test.rb:54:in `<main>' |
How about adding |
chenrui333
approved these changes
Dec 11, 2024
will followup on the esbuild test. |
github-actions
bot
added
the
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
label
Dec 11, 2024
updating in #200808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump-formula-pr
PR was created using `brew bump-formula-pr`
CI-no-fail-fast-deps
Continue dependent tests despite failing GitHub Actions matrix tests.
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
icu4c
ICU use is a significant feature of the PR or issue
long build
Set a long timeout for formula testing
long dependent tests
Set a long timeout for dependent testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.resource
blocks have been checked for updates.