Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esbuild: update test #200808

Merged
merged 1 commit into from
Dec 11, 2024
Merged

esbuild: update test #200808

merged 1 commit into from
Dec 11, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Dec 11, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

in #200689, esbuild test run never exists, thus explicitly adding process.exit() in the end. (thanks @ryenus for the idea)

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added nodejs Node or npm use is a significant feature of the PR or issue CI-no-bottles Merge without publishing bottles labels Dec 11, 2024
@chenrui333 chenrui333 mentioned this pull request Dec 11, 2024
1 task
@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Dec 11, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit 7ec8f84 Dec 11, 2024
22 checks passed
@BrewTestBot BrewTestBot deleted the update-esbuild-test branch December 11, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue nodejs Node or npm use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants