Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd 3.4.0 #43672

Closed
wants to merge 1 commit into from
Closed

etcd 3.4.0 #43672

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@chenrui333
Copy link
Member Author

@BrewTestBot test this please

@chenrui333
Copy link
Member Author

14:46:44 2019-09-01 15:46:35.747459 I | etcdserver/api: enabled capabilities for version 3.4
14:46:44 2019-09-01 15:46:35.748082 N | embed: serving insecure client requests on 127.0.0.1:2379, this is strongly discouraged!
14:46:44 ==> curl --silent -L http://127.0.0.1:2379/v2/keys/brew_test -XPUT -d value=Hello from brew test!
14:46:44 404 page not found
14:46:44 ==> curl --silent -L http://127.0.0.1:2379/v2/keys/brew_test
14:46:44 Error: etcd: failed
14:46:44 An exception occurred within a child process:
14:46:44 JSON::ParserError: 785: unexpected token at 'page not found
14:46:44 '

@chenrui333
Copy link
Member Author

In etcd-io/etcd#10935, v2 client support has been turned to false by default, so I have to introduce --enable-v2.

chenrui333
chenrui333 commented Sep 3, 2019
View reviewed changes
Formula/etcd.rb
@@ -58,15 +58,18 @@ def plist; <<~EOS
end

test do
ENV["ETCDCTL_API"] = "3"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now serve v3 API request by default.

@fxcoudert fxcoudert closed this in d59f546 Sep 4, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 11, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
@chenrui333 chenrui333 deleted the etcd-3.4.0 branch December 18, 2022 04:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chenrui333