Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc-arm-none-eabi 8-2019-q3-update (new formula) #45780

Closed
wants to merge 4 commits into from

Conversation

ProZsolt
Copy link
Contributor

@ProZsolt ProZsolt commented Oct 24, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This was removed from cask (Homebrew/homebrew-cask#56802)

version "8-2019-q3-update"
sha256 "e8a8ddfec47601f2d83f1d80c0600f198476f227102121c8d6a5a781d0c2eeef"

env :std
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not acceptable in Homebrew core.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


env :std

depends_on "wget" => :build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resources shouldn't be downloaded by the build script behind our back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully fixed. I have to wait to find out if it builds with homebrews' versions of packages.


system "./install-sources.sh"
system "./build-prerequisites.sh"
system "./build-toolchain.sh", "--skip_steps=manual"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be made to build closer to arm-linux-gnueabihf-binutils?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly no. build-toolchain.sh is a 952 line monster. Just the happy path is ~450. I don't think we want to reimplement it for homebrew and maintain future compatibility.

@fxcoudert
Copy link
Member

Hi @ProZsolt I'm sorry but the build process for this is simply not maintainable enough for us to accommodate in Homebrew core. You can ask for reinclusion in Homebrew casks given this cannot fit in core.

@fxcoudert fxcoudert closed this Dec 27, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 26, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants