Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-okta: remove gopath #47642

Closed
wants to merge 1 commit into from
Closed

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Dec 9, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Remove GOPATH as formula supports Go modules.

Relates to #47627.

@chenrui333 chenrui333 added the gopath deprecation Deprecate GOPATH in favor of Go Modules label Dec 10, 2019
@chenrui333
Copy link
Member

02:03:27 ==> brew test aws-okta --verbose
02:03:30 ==> FAILED
02:03:30 Testing aws-okta
02:03:30 /usr/bin/sandbox-exec -f /private/tmp/homebrew20191209-33328-7ko5vs.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/aws-okta.rb --verbose
02:03:30 Error: aws-okta: failed
02:03:30 An exception occurred within a child process:
02:03:30 NoMethodError: undefined method `chomp' for nil:NilClass

@alebcay
Copy link
Member Author

alebcay commented Dec 10, 2019

@BrewTestBot test this please.

@alebcay
Copy link
Member Author

alebcay commented Dec 10, 2019

I am unable to reproduce the test failure locally on Catalina.

@chenrui333
Copy link
Member

Works on my Catalina machine as well.

@chenrui333
Copy link
Member

@BrewTestBot test this please

@chenrui333
Copy link
Member

Still only failed on test step of catalina build. Go for the merge now.

@lock lock bot added the outdated PR was locked due to age label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gopath deprecation Deprecate GOPATH in favor of Go Modules outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants