Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devspace 4.3.4 #47678

Closed
wants to merge 1 commit into from
Closed

devspace 4.3.4 #47678

wants to merge 1 commit into from

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Dec 10, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Remove GOPATH as formula supports Go modules.

Relates to #47627.

@alebcay alebcay added the gopath deprecation Deprecate GOPATH in favor of Go Modules label Dec 10, 2019
@alebcay
Copy link
Member Author

alebcay commented Dec 10, 2019

==> brew test devspace --verbose
==> FAILED
Testing devspace
/usr/bin/sandbox-exec -f /private/tmp/homebrew20191210-70343-1j8qqcj.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/devspace.rb --verbose
==> /usr/local/Cellar/devspace/4.3.1/bin/devspace help
/usr/local/Cellar/devspace/4.3.1/bin/devspace: /usr/local/Cellar/devspace/4.3.1/bin/devspace: cannot execute binary file
Error: devspace: failed
An exception occurred within a child process:
  Test::Unit::AssertionFailedError: <0> expected but was
<126>.

I'm unable to reproduce this error locally on Catalina.

@alebcay
Copy link
Member Author

alebcay commented Dec 21, 2019

After some more research and trial/error, the error 126 is caused by file not being a valid executable. Fix incoming shortly.

@alebcay alebcay changed the title devspace: remove gopath devspace 4.3.4 Dec 21, 2019
@fxcoudert fxcoudert closed this in 8daa0df Dec 21, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gopath deprecation Deprecate GOPATH in favor of Go Modules outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant