Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc 9.0.1 #70475

Closed
wants to merge 2 commits into from
Closed

ghc 9.0.1 #70475

wants to merge 2 commits into from

Conversation

lukel97
Copy link
Contributor

@lukel97 lukel97 commented Feb 5, 2021

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 5, 2021
@carlocab
Copy link
Member

carlocab commented Feb 5, 2021

Thanks, @bubba. You need to update the binary resource block.

@carlocab
Copy link
Member

carlocab commented Feb 5, 2021

FYI, you used the wrong URL: https://downloads.haskell.org/~ghc/9.0.1/ghc-9.0.1-x86_64-apple-darwin.tar.xz

The URL you should've used was https://downloads.haskell.org/~ghc/9.0.1/ghc-9.0.1-src.tar.xz

I've fixed that for you.

@carlocab carlocab added build failure CI fails while building the software 10.14 Mojave is specifically affected labels Feb 5, 2021
@fishtreesugar
Copy link
Contributor

According to the GHC 9.0 migration guide:

ghc-bignum package replaces both integer-gmp and integer-simple.

do we still need to depend on gmp?

@carlocab
Copy link
Member

carlocab commented Feb 6, 2021

I guess not, but we also have the issue of ghc 9.0 not being compatible with Homebrew cabal-install: https://www.haskell.org/ghc/download_ghc_9_0_1.html

I think we may need to have a separate ghc@8.10 formula first, and everything that needs cabal-install (which must be all the formulae that use ghc...) should depend on that.

@carlocab carlocab mentioned this pull request Feb 6, 2021
@carlocab
Copy link
Member

carlocab commented Feb 6, 2021

@fishtreesugar, is ghc-bignum packaged as part of the source tarball? Can we just get rid of the gmp resource here, or would the formula need additional changes?

@fishtreesugar
Copy link
Contributor

is ghc-bignum packaged as part of the source tarball?

Yes.

Can we just get rid of the gmp resource here, or would the formula need additional changes?

Maybe we can add a build option to let users decide which bignum backend to use.

reference: https://github.com/ghc/ghc/blob/ghc-9.0/libraries/ghc-bignum/GMP.rst

@carlocab
Copy link
Member

carlocab commented Feb 7, 2021

Maybe we can add a build option to let users decide which bignum backend to use.

We don't do build options in homebrew/core. We'll have to pick one for the formula.

@fishtreesugar
Copy link
Contributor

We don't do build options in homebrew/core. We'll have to pick one for the formula.

Ok, we can respect ghc's default option (native backend) which did not depend on gmp.

@carlocab carlocab mentioned this pull request Feb 10, 2021
5 tasks
@carlocab
Copy link
Member

Merged in #70817.

@carlocab carlocab closed this Feb 17, 2021
@carlocab carlocab added the superseded PR was replaced by another PR label Feb 17, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 20, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 20, 2021
@chenrui333 chenrui333 added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. not merged PR was closed without being merged (and may need to be revisited) and removed not merged PR was closed without being merged (and may need to be revisited) labels Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
10.14 Mojave is specifically affected automerge-skip `brew pr-automerge` will skip this pull request build failure CI fails while building the software CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants