-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ghc 9.0.1 #70817
ghc 9.0.1 #70817
Conversation
ghc 9.0.1 doesn't suit as a replacement for ghc 8.10.4. None of the formulae that depend on ghc build with ghc 9.0.1, and ghc 9.0.1 doesn't even work with our I think most users of Thoughts/objections, @homebrew/core? |
I think we should follow our standards. Despite it being inconvenient right now, it is what users expect from homebrew. The caveats will tell users what to do. |
@carlocab versioned formulae should never conflict with each other. Either one or none of the versions should not be
|
we/I should probably add documentation and/or audits to ensure this is the case. |
This sounds good to me. Thanks Mike. |
Another option for formulae like this where this becomes a repeated problem is we get rid of |
I think there is an audit for this. There's also an allowlist, but that's practically empty at the moment. Though I guess the ideal is that it's empty, rather than almost empty.
I'm not sure we're in repeated-problem territory yet. ghc is also more manageable than python or openssl, since it has only a few dozen dependencies, rather than a few hundred. |
This does not have a gmp resource. It is no longer needed. [1] [1] https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.0#integer-gmp-11-integer-simple-ghc-bignum-10
- remove patch - update stdlib Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Only one failure on the Intel nodes: Tested this on GitHub nodes running Catalina and Big Sur, but building with the existing Same failure. |
|
Upstream confirmed that the failure isn't due to the version bump. This is blocking another PR (#70750), so I'm merging this one and fixing the |
This should fix the CI failure seen in Homebrew#70817.
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?ghc 9.0 only works with cabal-install 3.4 or later [1]. However, the latest stable release of cabal-install is 3.2. I've added a ghc@8.10 formula and switched all the formulae that use it to ghc@8.10.
I omitted revision bumps where ghc@8.10 is a build-only dependency.
Closes #70475.
Closes #70591.
[1] https://www.haskell.org/ghc/download_ghc_9_0_1.html