Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traefik@1: fix build by downgrading node@16 to node@14 #77021

Closed
wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented May 11, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Another build failure due to node@16 (and probably node-sass) seen in #76791 (comment)

Unlike #77018, I didn't add a comment as traefik@1 is a versioned formula (traefik is v2 and doesn't have node dependency). If a comment is preferred, it can be added.

I confirmed build failure with original Formula on local system with --build-from-source.
Also confirmed successful build after downgrade to node@14:

🍺  /opt/homebrew/Cellar/node@14/14.16.1_1: 4,377 files, 59.6MB
==> Installing traefik@1
==> yarn upgrade
==> yarn install
==> yarn run build
==> go generate
==> go build -o /opt/homebrew/Cellar/traefik@1/1.7.30/bin/traefik ./cmd/traefik
==> Caveats
traefik@1 is keg-only, which means it was not symlinked into /opt/homebrew,
because this is an alternate version of another formula.

If you need to have traefik@1 first in your PATH, run:
  echo 'export PATH="/opt/homebrew/opt/traefik@1/bin:$PATH"' >> ~/.zshrc


To have launchd start traefik@1 now and restart at login:
  brew services start traefik@1
Or, if you don't want/need a background service you can just run:
  traefik
==> Summary
🍺  /opt/homebrew/Cellar/traefik@1/1.7.30: 7 files, 78.9MB, built in 2 minutes 6 seconds

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue legacy Relates to a versioned @ formula nodejs Node or npm use is a significant feature of the PR or issue labels May 11, 2021
@cho-m cho-m mentioned this pull request May 11, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the traefik1-fix-build-node branch May 11, 2021 18:16
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue legacy Relates to a versioned @ formula nodejs Node or npm use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants