go 1.16.4

[Loyalsoldier]

Created with brew bump-formula-pr.

resource blocks may require updates.

[Loyalsoldier]

These formulas failed on Big Sur on Apple Silicon:

Error: 62 failed steps!
brew test --retry --verbose akamai
brew install --build-from-source argo
brew test --retry --verbose awsweeper
brew test --retry --verbose bazelisk
brew test --retry --verbose bitrise
brew install --build-from-source cf-tool
brew test --retry --verbose chart-testing
brew install --build-from-source chronograf
brew install --build-from-source circleci
brew install --build-from-source --only-dependencies clair
brew install --build-from-source clair
brew install --build-from-source consul
brew install --build-from-source --only-dependencies docker-machine-driver-hyperkit
brew install --build-from-source docker-machine-driver-hyperkit
brew install --build-from-source --only-dependencies dockviz
brew install --build-from-source dockviz
brew install --build-from-source drone-cli
brew install --build-from-source dvm
brew install --only-dependencies --include-test envconsul
brew test --retry --verbose envconsul
brew install --build-from-source --only-dependencies envoy
brew install --build-from-source envoy
brew test --retry --verbose etcd
brew install --build-from-source --only-dependencies fabio
brew install --build-from-source fabio
brew test --retry --verbose fortio
brew install --build-from-source --only-dependencies geoipupdate
brew install --build-from-source geoipupdate
brew install --build-from-source --only-dependencies git-annex-remote-rclone
brew install --build-from-source git-annex-remote-rclone
brew install --build-from-source gotop
brew install --build-from-source ioctl
brew install --build-from-source --only-dependencies ironcli
brew install --build-from-source ironcli
brew install --build-from-source istioctl
brew test --retry --verbose jabba
brew test --retry --verbose keptn
brew install --build-from-source kube-linter
brew install --build-from-source kustomize
brew install --build-from-source logcli
brew install --build-from-source mpdviz
brew install --build-from-source pilosa
brew install --build-from-source promtail
brew test --retry --verbose server-go
brew install --build-from-source ship
brew install --build-from-source source-to-image
brew install --build-from-source --only-dependencies ssh-vault
brew install --build-from-source ssh-vault
brew install --only-dependencies --include-test stolon
brew test --retry --verbose stolon
brew install --build-from-source td
brew install --build-from-source teleconsole
brew install --build-from-source telegraf
brew test --retry --verbose terrascan
brew test --retry --verbose terrascan
brew install --build-from-source traefik@1
brew install --build-from-source --only-dependencies vault
brew install --build-from-source vault
brew install --build-from-source --only-dependencies vert
brew install --build-from-source vert
brew install --build-from-source virgil
brew fetch --retry vitess
Error: Process completed with exit code 1.

[carlocab]

Most of the ARM failures haven't been bottled. These are the ones that have been:

chronograf
fortio
istioctl
kustomize
logcli
promtail
ship
td
telegraf
terrascan
traefik@1

[carlocab]

Catalina:

Error: 15 failed steps!
brew install --build-from-source chronograf
brew test --retry --verbose darksky-weather
brew test --retry --verbose darksky-weather
brew test --retry --verbose fortio
brew install --build-from-source grafana
brew install --build-from-source kustomize
brew install --build-from-source logcli
brew install --build-from-source promtail
brew install --build-from-source ship
brew install --build-from-source td
brew install --build-from-source telegraf
brew test --retry --verbose terrascan
brew test --retry --verbose terrascan
brew install --build-from-source traefik@1
brew install --build-from-source vitess

Mojave:

Error: 12 failed steps!
brew install --build-from-source aws-iam-authenticator
brew install --build-from-source chronograf
brew install --build-from-source kustomize
brew install --build-from-source logcli
brew install --build-from-source promtail
brew install --build-from-source ship
brew install --build-from-source td
brew install --build-from-source telegraf
brew test --retry --verbose terrascan
brew test --retry --verbose terrascan
brew install --build-from-source traefik@1
brew install --build-from-source vitess

[Loyalsoldier]

Then what's next?

[carlocab]

Then what's next?

Investigate these test failures and try to fix as many as we can.

Big Sur:

Error: 12 failed steps!
brew install --build-from-source chronograf
brew test --retry --verbose fortio
brew install --build-from-source kustomize
brew install --build-from-source logcli
brew install --build-from-source promtail
brew install --build-from-source ship
brew install --build-from-source td
brew install --build-from-source telegraf
brew test --retry --verbose terrascan
brew test --retry --verbose terrascan
brew install --build-from-source traefik@1
brew install --build-from-source vitess

[andig]

I find this a bit confusing. Go 1.16.4 has zero changes that should not work where 1.16.3 has worked?

[cho-m]

Will update this post with some of my analysis of failures:

Go-related failures or in need of further triage

• kustomize kustomize: fix build error due to multiple tags with HEAD #77023 - EDIT: git tag --contains HEAD is outputting multiple tags, breaking go build command.
• fortio - somehow fortio (1.15.2) version command is outputting 1.15.0. EDIT: odd failure as locally building go 1.16.4 and fortio has no test issue for me. Also Mojave node passed. May need to rerun CI.

node@16 + node-sass failures (either need node@14 or node-sass@6.0.0)

• chronograf chronograf: fix build issue from incompatible node-sass@4.13 and node@16 #77018 - chronograf lock file uses node-sass@4.13, which doesn't support node@16
• ship ship: fix build - incompatible node@16 and node-sass@4 #77533 - Similar failure to chronograf (C++14 failure around libsass dependency)
• traefik@1 traefik@1: fix build by downgrading node@16 to node@14 #77021 - Different error than other 2, but failure is on same module: Cannot find module 'node-sass'

SHA256 mismatch failures (need to confirm with upstream and then update formulae):

• telegraf telegraf: fix v1.18.2 source tarball sha256 hash #77029 - Source tar SHA256 mismatch. Homebrew updated 9 days ago (telegraf 1.18.2 #76216).
• vitess - Source tar SHA256 mismatch. Homebrew updated 5 days ago (vitess 10.0.1 #76507).
• logcli - Source tar SHA256 mismatch.
• promtail - Same repo as logcli, so same failure
• td - Another SHA256 mismatch

Broken Formula tests (not too sure why CI didn't detect on last Formula PR):

• terrascan terrascan 1.6.0 #77325 - confirmed test failure with current bottle on local system:
  EDIT: Test fix added with linked 1.6.0 PR

Maybe Network Issue (Probably can just re-run CI):

• darksky-weather - Only Catalina failed from 403 on https://geocode.jessfraz.com/forecast
• aws-iam-authenticator - Only Mojave failed on git clone error: RPC failed; curl 56 LibreSSL SSL_read: error:06FFF064:digital envelope
• grafana - Only Catalina failed with ECONNRESET

[jlk]

Folks - hey from terrascan team. :) Just saw this while passing through - we'll take a peek at this from our side, as well...

[cho-m]

May want to rebase and rerun CI to test on latest Homebrew state.

From previous run, the failures that probably will reoccur are 4 SHA checksum mismatch errors (vitess, logcli, promtail, and td), which require updating the sha256 checksum in each formula after confirming with the upstream source that the new checksum is correct and not the result of a malicious actor.

It is possible that new failures will occur due to formulae being updated during the timeframe.

[cho-m]

Will update with latest failures here.
Can later decide if any are actually go-update blocking failures.

Failures:

• grafana (10.15, 11) - may be network issue? - Also had recent update grafana 7.5.7 #77608 so might be okay now.
• istioctl (11-arm) - Doesn't build on ARM as-is - Probably not blocking. Possible fix in istioctl 1.10.0 #77139
• youtubedr (ALL Intel) - test failure - new version was merged after test youtubedr 2.7.0 #77619, so maybe fixed?

  Error: youtubedr: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected /Title:\ \ \ \ \ \ \ History\ of\ homebrew\-core/ to match nil.
  

• inlets (10.14) - test failure

  2021/05/19 15:51:44 Starting client - version 3.0.1
  2021/05/19 15:51:44 Upstream:  => http://localhost:62671
  time="2021/05/19 15:51:44" level=info msg="Connecting to proxy" url="ws://localhost:62672/tunnel"
  time="2021/05/19 15:51:44" level=error msg="Failed to connect to proxy. Empty dialer response" error="dial tcp [::1]:62672: connect: connection refused"
  time="2021/05/19 15:51:44" level=error msg="Remotedialer proxy error" error="dial tcp [::1]:62672: connect: connection refused"
  

---

Checksum mismatches. May not be blocking merge?

• linkerd (ALL) - commit mismatch

  ==> Checking out tag stable-2.10.2
  HEAD is now at 5535e9c4 Add service annotations fix to stable 2.10.2 (#6126)
  Error: stable-2.10.2 tag should be fd03538b2641c56f6e6dc3bb5de1669ccd96278a
  but is actually 5535e9c4edda7f5a8d8d21e351b61425bd3a8208
  

• td (ALL) - SHA mismatch
• teleport (ALL) - SHA mismatch
• kops (ALL Intel) - SHA mismatch
• vitess (ALL Intel) - SHA mismatch

[cho-m]

@carlocab Can you check if we can go ahead with merge here?
Pretty much all failures are checksum errors (linkerd, td, telegraf, and vitess).
Only other one is istioctl on Catalina, which was a network issue on CI node.

---

Big Sur ARM

brew install --build-from-source linkerd
brew install --build-from-source td
brew install --build-from-source telegraf

Big Sur

brew install --build-from-source linkerd
brew install --build-from-source td
brew install --build-from-source telegraf
brew install --build-from-source vitess

Catalina

brew install --build-from-source istioctl
brew install --build-from-source linkerd
brew install --build-from-source td
brew install --build-from-source telegraf
brew install --build-from-source vitess

Mojave

brew install --build-from-source linkerd
brew install --build-from-source td
brew install --build-from-source telegraf
brew install --build-from-source vitess

---

EDIT:
On side note, I can't believe we hit another checksum issue with telegraf.
We dealt with one for 1.18.2 and see another for 1.18.3.

[carlocab]

LGTM. Thanks for working on this, @cho-m.

[BrewTestBot]

@carlocab has triggered a merge.

[ldemailly]

#78670 maybe will eliminate the issue (though there shouldn't have been an issue at all so it's a bit mysterious)