Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telegraf: fix v1.18.2 source tarball sha256 hash #77029

Merged
merged 1 commit into from
May 14, 2021

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented May 11, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Pending on upstream confirmation of tarball update: influxdata/telegraf#9260
SHA256 mismatch failure seen in #76791 (comment)

For now, I haven't touched the livecheck as I don't know if the GitHub or download page is better to monitor.

@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label May 11, 2021
@cho-m cho-m mentioned this pull request May 11, 2021
@cho-m
Copy link
Member Author

cho-m commented May 13, 2021

@nandahkrishna We have confirmation that retag was done by upstream due to an issue with Makefile in release.

Livecheck can probably remain as-is since Homebrew would have still hit the issue with homepage URL.

See: influxdata/telegraf#9260 (comment), quoted below with my own bolded parts:

Hi @ cho-m, when I built 1.18.2 there was a makefile bug that caused packages for a few platforms not to be built. I fixed the bug and retagged 1.18.2. This does appear to be the same situation as # 2140, so the resolution again is for us not to retag after packages have been published. I'll update our release documentation to highlight this policy.

Having Homebrew monitor https://portal.influxdata.com/downloads/ would not have helped this time since we published there before we noticed the missing packages.

Sorry for the inconvenience, and thanks for your work packaging Telegraf on Homebrew!

@nandahkrishna
Copy link
Member

Thanks for checking, @cho-m. Is the revision bump required though?

@cho-m cho-m force-pushed the telegraf-1.18.2-fix-sha256 branch from cd1479a to b51f953 Compare May 14, 2021 03:22
@cho-m
Copy link
Member Author

cho-m commented May 14, 2021

@nandahkrishna I think we can remove it as changes were some release (Makefile/CI) stuff and bottles built fine for Homebrew last time.

Not too sure what exact commit was used for last build, but I am guessing:
https://github.com/influxdata/telegraf/compare/00f754ab0a68ecb993b61e23794572a3ca56af23..v1.18.2

@nandahkrishna nandahkrishna merged commit 14a4c76 into Homebrew:master May 14, 2021
@cho-m cho-m deleted the telegraf-1.18.2-fix-sha256 branch May 14, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants