Merge pull request #376 from MehdiK/fix-IConvertible-warning

Fixes the IConvertible warning thrown on Windows Phone reported on #317
Humanizr · Feb 3, 2015 · aa144ba · aa144ba
2 parents 352b019 + f807583
commit aa144ba
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/release_notes.md b/release_notes.md
@@ -1,4 +1,5 @@
 ###In Development
+ - [#376](https://github.com/MehdiK/Humanizer/pull/376): Fixes the IConvertible warning thrown on Windows Phone reported on #317
 
 [Commits](https://github.com/MehdiK/Humanizer/compare/v1.33.0...master)
 

diff --git a/src/Humanizer.Tests/DateHumanizeDefaultStrategyTests.cs b/src/Humanizer.Tests/DateHumanizeDefaultStrategyTests.cs
@@ -94,7 +94,7 @@ public void HoursFromNowNotTomorrow(int hours, string expected)
         [Theory]
         [InlineData(1, "yesterday")]
         [InlineData(10, "10 days ago")]
-        [InlineData(28, "28 days ago")]
+        [InlineData(27, "27 days ago")]
         [InlineData(32, "one month ago")]
         public void DaysAgo(int days, string expected)
         {
@@ -104,7 +104,7 @@ public void DaysAgo(int days, string expected)
         [Theory]
         [InlineData(1, "tomorrow")]
         [InlineData(10, "10 days from now")]
-        [InlineData(28, "28 days from now")]
+        [InlineData(27, "27 days from now")]
         [InlineData(32, "one month from now")]
         public void DaysFromNow(int days, string expected)
         {

diff --git a/src/Humanizer.Tests/DehumanizeToEnumTests.cs b/src/Humanizer.Tests/DehumanizeToEnumTests.cs
@@ -86,7 +86,7 @@ public void HonorsLocalizedDisplayAttribute()
             Assert.Equal(EnumUnderTest.MemberWithLocalizedDisplayAttribute, EnumTestsResources.MemberWithLocalizedDisplayAttribute.DehumanizeTo(typeof(EnumUnderTest)));
         }
 
-        struct DummyStructWithEnumInterfaces : IComparable, IFormattable, IConvertible
+        struct DummyStructWithEnumInterfaces : IComparable, IFormattable
         {
             public int CompareTo(object obj)
             {

diff --git a/src/Humanizer/EnumDehumanizeExtensions.cs b/src/Humanizer/EnumDehumanizeExtensions.cs
@@ -17,7 +17,7 @@ public static class EnumDehumanizeExtensions
         /// <exception cref="NoMatchFoundException">Couldn't find any enum member that matches the string</exception>
         /// <returns></returns>
         public static TTargetEnum DehumanizeTo<TTargetEnum>(this string input)
-            where TTargetEnum : struct, IComparable, IFormattable, IConvertible
+            where TTargetEnum : struct, IComparable, IFormattable
         {
             return (TTargetEnum)DehumanizeToPrivate(input, typeof(TTargetEnum), OnNoMatch.ThrowsException);
         }