-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MakePRI warning 0xdef01051 while compiling Windows 8.1 Store app #317
Comments
Oh! This is the first I'm seeing this! It seems like a bug in Microsoft Advertising SDK. Not sure about this tbh. Have you tried the workaround proposed in the article? |
I haven't. I was first looking to know whether this was a known issue or not. I have been using Humanizer successfully in a .NET 4.0 project, and was trying to introduce it to a Windows 8/WP 8.1 store app but I had to roll it back until I find out a fix for this. If I have some time I will try the workaround. |
I know that some teams have been successfully using Humanizer in Windows 8 applications for quite a while; but WP8.1 support is very new and I'm not sure if anyone has used it. Please keep us updated. |
We need to fill in the English resources for those special cases of another cultures. Dual in English is the same as plural. Just make sure to add those in Resource.resx. |
I'm going to close this issue as it seems like a bug in another framework. @pombeirp please let us know if you find a fix for this issue. |
@MehdiK Sorry for taking so long to give this a try. I confirm that adding the missing resources to |
Thanks for getting back to me on this. I know this is not ideal; but do you think it's possible for you to disable this warning for your build? You can see a solution here. We also have #59 which will fix this for English users. Other than these, the only thing I can think of is to add every single key to all the resources which is going to pollute the entire solution and I am not a fond of. |
@MehdiK I think you don't have to add the keys to all resources, but only to the english one. Because it's the default one baked in the main dll. |
Are you sure @mexx? If so, it isn't quite as bad. |
@MehdiK yes, that is also what I observed. |
You have an English only project though
|
@MehdiK I'm currently localizing my project (and incidently consider Humanizer as a helpful prerequisite for this), so I can confirm that the problem disappears even on a project with multiple languages. I am currently adding the missing resources to Humanizer - if you'd like I can make a pull request and avoid you the trouble of adding the resources yourself. |
Thanks a lot for the confirmation. In that case that would be an acceptable Please make a PR based on your additions when all the warnings disappear. Thanks.
|
Done. |
Add special case resources to neutral language. Fixes #317
:-( After taking the NuGet package from the CI server I started getting an error message when compiling the app project (happens when the MakePRI is apparently merging the resources). As much as that pains me, I think I'll have to drop this effort. It seems WinRT is just too picky regarding resources...
UPDATE: Just found this:
If I remove the satellite DLL folders from the packages folder ( |
The problem seems to be caused by two new languages: zh-CHS and zh-CHT. By removing these folders from the package, there is no longer a |
I think this is now fixed through #374 & it's been released to NuGet. Would you please be able to verify if the warnings have gone away? |
@MehdiK They are indeed gone! I still have a minor one though, not sure if you've seen it before: I've seen a similar issue in AutoMapper/AutoMapper#658 |
Fixes the IConvertible warning thrown on Windows Phone reported on #317
After I added Humanizer to the solution (an English only project), I started getting the following warnings during the build:
When I search the web for the warning code, I came across this: http://social.msdn.microsoft.com/Forums/windowsapps/en-US/2554a1c6-f1b8-45b1-a690-881d835407d0/how-to-solve-makepri-warning-0xdef01051-no-default-or-neutral-resource-given-for?forum=toolsforwinapps
Is this a known issue?
Thanks.
The text was updated successfully, but these errors were encountered: