Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor packages to enable excluding locales #469

Merged
merged 15 commits into from
Nov 30, 2015
Merged

Conversation

clairernovotny
Copy link
Member

This PR tracks #59

@MehdiK
Copy link
Member

MehdiK commented Oct 29, 2015

Looks good. Thanks @onovotny.

@MehdiK
Copy link
Member

MehdiK commented Oct 29, 2015

I am just a bit unsure about Humanizer.all name although I'm not sure what else I would call it!

@MehdiK
Copy link
Member

MehdiK commented Oct 29, 2015

I am just thinking that when/if there are other packages as part of the library, then all implies everything while we just mean all the resources.

@clairernovotny
Copy link
Member Author

So right now, I have Humanizer as the meta-package that pull in every Locale and Humanizer.Core. Essentially, it preserves current behavior.

For people that don't want all locales, they can just directly install the Humanizer.Core package.

Nothing has changed with the dll's or their names, it's all just packaging.

@MehdiK
Copy link
Member

MehdiK commented Oct 29, 2015

Nice 👍

@clairernovotny
Copy link
Member Author

Testing on UWP has turned up an error installing the localized packages...a false error I believe. @emgarten, can you please assist (email with details should be in your inbox)

@clairernovotny
Copy link
Member Author

@emgarten: easy repro, check out the features/integration branch and try to add Humanizer.Core.ar to it via NuGet (selecting the CI feed). You'll see an error about it not being compatible with a UWP app. If you add to the project.json manually, you get that error on build instead.

@clairernovotny
Copy link
Member Author

There's a fix for this but it's dependent on this PR being merged in (and shipped to the public):
NuGet/NuGet.Client#95

@clairernovotny clairernovotny merged commit cb93656 into dev Nov 30, 2015
@clairernovotny clairernovotny deleted the features/nuget-split branch November 30, 2015 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants