Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsCompatible fixes for project.json restore #95

Closed
wants to merge 1 commit into from
Closed

IsCompatible fixes for project.json restore #95

wants to merge 1 commit into from

Conversation

emgarten
Copy link
Member

@emgarten emgarten commented Nov 4, 2015

This change contains fixes around the guard rails IsCompatible check.

  • Count satellite packages that contain only resources as compatible
  • Perf: use Count > 0 instead of .Any()
  • Casing fix for ref/ and lib/ folder checks

//cc @yishaigalatzer @MeniZalzman @deepakaravindr @feiling @anurse

@yishaigalatzer
Copy link
Contributor

Test?

@clairernovotny clairernovotny mentioned this pull request Nov 4, 2015
Merged
@emgarten
Copy link
Member Author

emgarten commented Nov 5, 2015

Merged 8b67737

@emgarten emgarten closed this Nov 5, 2015
@emgarten emgarten deleted the emgarten/satelliteCompat branch November 5, 2015 01:23
@clairernovotny
Copy link

What release will this make it into?

@yishaigalatzer
Copy link
Contributor

Not sure yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emgarten @yishaigalatzer @clairernovotny @dnfclas