refactor(signifies) range from NodeShape to Shape #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danaivach
requested review from
FabienGandon,
andreiciortea and
maximelefrancois86
|
Hi @maximelefrancois86, can you review this PR? I validate the proposed changes. |
|
This PR has been converted to a draft pending the completion of discussions in the related issue. |
FabienGandon
approved these changes
Nov 24, 2023
|
@andreiciortea and @maximelefrancois86 could you submit your review please? |
andreiciortea
approved these changes
Nov 29, 2023
maximelefrancois86
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the range of
hmas:signifiesfromsh:NodeShapetosh:Shape.The update supports the more generic definition of
hmas:signifies, given that no semantic or syntactic conflicts have been identified when using an instance of anysh:Shape(be itsh:NodeShapeorsh:PropertyShape) as the value ofhmas:signifies.See #176 for more details.