-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial IamSlice suggestion #637
Conversation
Depending on what is filtered it returns a boolean mask as a pd.Series or as a numpy array :/
Codecov Report
@@ Coverage Diff @@
## main #637 +/- ##
=======================================
- Coverage 94.5% 94.4% -0.2%
=======================================
Files 57 58 +1
Lines 5662 5704 +42
=======================================
+ Hits 5356 5388 +32
- Misses 306 316 +10
Continue to review full report at Codecov.
|
Hmm ... that's a pickle. Not sure who could do a review. For me this was basically just trying to get something out to start a discussion. Undesirable properties (i am aware of):
Other than that i am pretty fine with the result. How far is test-coverage, when your PRs are merged in? |
I don't think that this is a problem. I'd even remove the |
* Add a proper length attribute * Use pandas native method Co-authored-by: Jonas Hörsch <coroa@posteo.de>
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
closing in favor of #657 |
This would be a possible way to add an IamSlice feature proposed in #630 .
Please confirm that this PR has done the following:
Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following:
Description of PR
Please describe the changes introduced by this PR.