Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a proper length attribute #643

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

danielhuppmann
Copy link
Member

Description of PR

This PR fixes the __len__ attribute, which should only count the timeseries data points actually included in the slice.

@danielhuppmann danielhuppmann requested a review from coroa March 9, 2022 19:54
@danielhuppmann danielhuppmann self-assigned this Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #643 (5326d92) into add-iamslice (8fe4376) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           add-iamslice    #643   +/-   ##
============================================
  Coverage          94.4%   94.4%           
============================================
  Files                57      58    +1     
  Lines              5698    5702    +4     
============================================
+ Hits               5380    5384    +4     
  Misses              318     318           
Impacted Files Coverage Δ
pyam/core.py 93.5% <100.0%> (+<0.1%) ⬆️
tests/test_slice.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe4376...5326d92. Read the comment docs.

pyam/core.py Outdated Show resolved Hide resolved
@coroa coroa merged commit 478112f into IAMconsortium:add-iamslice Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants