Custom scanner implementation for Dialog Tag Language #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
|
This PR has been validated by N. Latif and is (finally) ready for a review. |
M-DLB
reviewed
Dec 4, 2023
Scanners/README.md
Outdated
| * Clone the IBM/DBB repository into IDZ/Eclipse. | ||
| * Import the scanner implementation as a JAVA project | ||
| * Download the `<DBB-HOME>/lib/dbb.core_2.0.x.x.jar` package from your IBM DBB toolkit installation to your development environment | ||
| * Fix the build setup and of the scanner project. |
Scanners/README.md
Outdated
|
|
||
| * Clone the IBM/DBB repository into IDZ/Eclipse. | ||
| * Import the scanner implementation as a JAVA project | ||
| * Download the `<DBB-HOME>/lib/dbb.core_2.0.x.x.jar` package from your IBM DBB toolkit installation to your development environment |
There was a problem hiding this comment.
Maybe we should explicitly say "from your IBM DBB toolkit installation on z/OS Unix System Services to..."
Scanners/README.md
Outdated
| * Select the previously created runner configuration | ||
| * Select the export destination | ||
| * In the Library handling section, select to `Copy required libraries into a sub-folder next to the generated JAR` option | ||
| * Upload the generated JAR to z/OS Unix system services |
There was a problem hiding this comment.
"Copy the generated JAR to z/OS Unix system services as binary"
.project
Outdated
Comment on lines
1
to
11
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <projectDescription> | ||
| <name>dbb</name> | ||
| <comment></comment> | ||
| <projects> | ||
| </projects> | ||
| <buildSpec> | ||
| </buildSpec> | ||
| <natures> | ||
| </natures> | ||
| </projectDescription> |
There was a problem hiding this comment.
Do we need to have a .project for the whole dbb repository?
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
M-DLB
reviewed
Dec 4, 2023
Scanners/README.md
Outdated
|
|
||
| Sample | Description | ||
| --- | --- | ||
| [DTL Scanner](DTL%20Scanner) | A custom scanner implementation for z/OS ISPF Dialog Tag Language to detect it's dependencies. zAppBuild contains the language script for DTL. The scanner implementation leverages regex patterns to identify the referenced include files. |
There was a problem hiding this comment.
Small typo here: it's dependencies --> its dependencies
Sorry I missed that.
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBB has an extensibility mechanism to contribute your own dependency scanner for languages that either is not covered by the DBB product itself or that you might use some custom syntax, that is custom to your environment.
This contribution from @campagboy is outlining how to build a customer scanner using the AbstractDependencyScanner API of DBB for the Dialog Tag Language in ISPF.
The DTL scanner comes with the java project, that you need to build with then add to the JAVA classpath.
Also combining the default DependencyScanner is possible with your own parsing logic is possible by writing a new scanner that invokes the default DependencyScanner then adds your own dependencies.