Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Cross-reference fides options documentation #1152

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 25, 2023

@dweindl dweindl requested review from PaulJonasJost and a team as code owners October 25, 2023 08:07
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #1152 (264654c) into develop (160c2a8) will decrease coverage by 3.80%.
Report is 400 commits behind head on develop.
The diff coverage is 87.95%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #1152      +/-   ##
===========================================
- Coverage    88.16%   84.37%   -3.80%     
===========================================
  Files           79      148      +69     
  Lines         5257    11645    +6388     
===========================================
+ Hits          4635     9825    +5190     
- Misses         622     1820    +1198     
Files Coverage Δ
pypesto/C.py 100.00% <100.00%> (ø)
pypesto/__init__.py 100.00% <100.00%> (ø)
pypesto/engine/__init__.py 100.00% <100.00%> (ø)
pypesto/engine/multi_process.py 93.10% <100.00%> (+0.79%) ⬆️
pypesto/engine/multi_thread.py 100.00% <100.00%> (ø)
pypesto/engine/single_core.py 100.00% <100.00%> (ø)
pypesto/engine/task.py 100.00% <100.00%> (ø)
pypesto/ensemble/__init__.py 100.00% <100.00%> (ø)
pypesto/ensemble/task.py 100.00% <100.00%> (ø)
pypesto/hierarchical/__init__.py 100.00% <100.00%> (ø)
... and 138 more

Copy link
Contributor

@Doresic Doresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change. I was looking for these exact options myself a couple of days ago. Good to have them here directly referenced. Thanks!

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍🏼

@dweindl dweindl merged commit e5c4297 into develop Oct 25, 2023
18 checks passed
@dweindl dweindl deleted the doc_fides branch October 25, 2023 10:32
This was referenced Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants