Fix incorrect types in pypesto.result.profile.ProfilerResult #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make all `*_path` attributes numpy arrays as promised in the type hints This caused ICB-DCM#1205, because some entries were just plain `nan`. Fixes ICB-DCM#1205. * Fixes a lurking issue of potentially mismatching path lengths If e.g. x_path with length >1 was passed, but any of the default arguments would be missing, the *_paths wouldn't be aligned properly * Remove some unnecessary complexity
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1210 +/- ##
===========================================
- Coverage 83.99% 78.75% -5.25%
===========================================
Files 148 148
Lines 11802 11799 -3
===========================================
- Hits 9913 9292 -621
- Misses 1889 2507 +618 ☔ View full report in Codecov by Sentry. |
PaulJonasJost
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all
*_pathattributes numpy arrays as promised in the type hintsThis caused
store.write_result: ValueError: 1 indexing arguments for 0 dimensions #1205, because some entries were just plainnan. Fixesstore.write_result: ValueError: 1 indexing arguments for 0 dimensions #1205.Fixes a lurking issue of potentially mismatching path lengths
If e.g.
x_pathwith length >1 was passed, but any of the default arguments would be missing, the*_pathswouldn't be aligned properly. I don't think this problem occurred here yet.Remove some unnecessary complexity