Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect types in pypesto.result.profile.ProfilerResult #1210

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Fix incorrect types in pypesto.result.profile.ProfilerResult #1210

merged 3 commits into from
Nov 22, 2023

Commits on Nov 21, 2023

  1. Fix incorrect types in pypesto.result.profile.ProfilerResult 

    * Make all `*_path` attributes numpy arrays as promised in the type hints

  This caused ICB-DCM#1205, because some entries were just plain `nan`. Fixes ICB-DCM#1205.

* Fixes a lurking issue of potentially mismatching path lengths

  If e.g. x_path with length >1 was passed, but any of the default arguments would be missing,
  the *_paths wouldn't be aligned properly

* Remove some unnecessary complexity
    @dweindl
    dweindl committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2f56bf3 View commit details
    Browse the repository at this point in the history

  2. ..

    @dweindl
    dweindl committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    58d33fd View commit details
    Browse the repository at this point in the history

  3. ..

    @dweindl
    dweindl committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    22724d3 View commit details
    Browse the repository at this point in the history