Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadrunner handling of petab issue 0019 #1419

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

PaulJonasJost
Copy link
Collaborator

Issue happened, as initial value override was always assumed to happen in linear scale.

@PaulJonasJost PaulJonasJost self-assigned this Jun 20, 2024
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

pypesto/objective/roadrunner/petab_importer_roadrunner.py Outdated Show resolved Hide resolved
pypesto/objective/roadrunner/petab_importer_roadrunner.py Outdated Show resolved Hide resolved
pypesto/objective/roadrunner/petab_importer_roadrunner.py Outdated Show resolved Hide resolved
pypesto/objective/roadrunner/petab_importer_roadrunner.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Doresic Doresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.03%. Comparing base (0bf7f36) to head (91cc859).

Files Patch % Lines
.../objective/roadrunner/petab_importer_roadrunner.py 80.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1419      +/-   ##
===========================================
- Coverage    83.88%   82.03%   -1.85%     
===========================================
  Files          160      160              
  Lines        13096    13107      +11     
===========================================
- Hits         10985    10752     -233     
- Misses        2111     2355     +244     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulJonasJost PaulJonasJost merged commit 825550a into develop Jun 25, 2024
16 of 18 checks passed
@PaulJonasJost PaulJonasJost deleted the fix_petab_issue_0019 branch June 25, 2024 13:57
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants