Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roadrunner handling of petab issue 0019 #1419

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Roadrunner handling of petab issue 0019 #1419

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de4006b
Further distinction between initial value override based on parameter…
PaulJonasJost Jun 20, 2024
91cc859
Suggestions from PR
PaulJonasJost Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 34 additions & 8 deletions pypesto/objective/roadrunner/petab_importer_roadrunner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,15 +211,41 @@ def create_parameter_mapping(self):
preeq_id = condition.get(PREEQUILIBRATION_CONDITION_ID)
sim_id = condition.get(SIMULATION_CONDITION_ID)
if preeq_id:
mapping_per_condition[0][
override
] = self.petab_problem.condition_df.loc[preeq_id, override]
mapping_per_condition[2][override] = "lin"
parameter_id_or_value = (
self.petab_problem.condition_df.loc[preeq_id, override]
)
mapping_per_condition[0][override] = parameter_id_or_value
if isinstance(parameter_id_or_value, str):
mapping_per_condition[2][
override
] = self.petab_problem.parameter_df.loc[
parameter_id_or_value, "parameterScale"
PaulJonasJost marked this conversation as resolved.
Show resolved Hide resolved
]
elif isinstance(parameter_id_or_value, numbers.Number):
mapping_per_condition[2][override] = "lin"
PaulJonasJost marked this conversation as resolved.
Show resolved Hide resolved
else:
raise ValueError(
"The parameter value in the condition table "
"is not a number or a parameter_id."
PaulJonasJost marked this conversation as resolved.
Show resolved Hide resolved
)
if sim_id:
mapping_per_condition[1][
override
] = self.petab_problem.condition_df.loc[sim_id, override]
mapping_per_condition[3][override] = "lin"
parameter_id_or_value = (
self.petab_problem.condition_df.loc[sim_id, override]
)
mapping_per_condition[1][override] = parameter_id_or_value
if isinstance(parameter_id_or_value, str):
mapping_per_condition[3][
override
] = self.petab_problem.parameter_df.loc[
parameter_id_or_value, "parameterScale"
]
elif isinstance(parameter_id_or_value, numbers.Number):
mapping_per_condition[3][override] = "lin"
else:
raise ValueError(
"The parameter value in the condition table "
"is not a number or a parameter_id."
PaulJonasJost marked this conversation as resolved.
Show resolved Hide resolved
)
return mapping

def create_objective(
Expand Down
Loading