-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal pytest plugin to verify that generated files are cleaned up by tests #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksbeattie
requested review from
ksbeattie and
aasgerr
and removed request for
aasgerr
September 12, 2024 18:39
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1488 +/- ##
==========================================
- Coverage 76.84% 76.83% -0.02%
==========================================
Files 376 376
Lines 61091 61170 +79
Branches 13505 13518 +13
==========================================
+ Hits 46948 46999 +51
- Misses 11762 11788 +26
- Partials 2381 2383 +2 ☔ View full report in Codecov by Sentry. |
lbianchi-lbl
requested review from
bpaul4,
MAZamarripa,
andrewlee94,
avdudchenko,
rundxdi and
dallan-keylogic
as code owners
September 26, 2024 18:43
ksbeattie
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ksbeattie
requested review from
blnicho
and removed request for
bpaul4,
MAZamarripa,
andrewlee94 and
avdudchenko
September 26, 2024 18:46
blnicho
approved these changes
Sep 26, 2024
lbianchi-lbl
added a commit
that referenced
this pull request
Oct 1, 2024
…up by tests (#1488) * Add pytest plugin to verify that test modules clean up any generated file * Format with Black and remove unused import * Add docstring to make Pylint happy * Format with Black * Switch to per-test file checks and Python 3.9+ type hinting * Apply fixtures to offending tests * Try resolving next batch of failures * Try addressing two failures * Switch to using module-level fixture for tmp_path workdir (cherry picked from commit 9ee1fad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
idaes.core.dmf.util
through manipulation of temporary directories and/or the working directoryLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: