forked from USC-ACTLab/crazyswarm
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature download usd python layer #520
Open
julienthevenoz
wants to merge
24
commits into
main
Choose a base branch
from
feature_downloadUSD_python_layer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…finite_flight to crazyflie_examples
…finite_flight to crazyflie_examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to add the "download SD over radio" feature directly to the python layer so that it can be called while crazyserver is running (instead of having to shut down crazyserver to free the radio for the download), allowing it to be integrated in the middle of a crazyflie_example script for example. This is still work in progress
Problems :
Main problem : The typical way we use to call the service in crazyflie.py (a while loop of rcly.spin_once until future.done() == True) doesn't seem to work. Neither does the rclpy.spin_until_future_complete(). Both produce the same error "File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 711, in wait_for_ready_callbacks return next(self._cb_iter)
ValueError: generator already executing"
Secondary problem : sometimes the script stays blocked in main() at the "cf.uploadTrajectory(0, 0, traj1)" line. The is_crashed thread runs, but the trajectory is never uploaded (which means the cf doesn't fly).